test: use Rstest as Rspress's test framework #2413
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the test framework from Vitest to Rstest across the entire Rspress project. The migration involves updating configuration files, test imports, mocking syntax, and snapshot headers to use the new testing framework.
- Replace Vitest configuration with Rstest configuration
- Update all test file imports from 'vitest' to '@rstest/core'
- Change mocking syntax from
vi.mock()tors.mock()andvi.fn()tors.fn()
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vitest.workspace.ts | Complete removal of Vitest workspace configuration |
| rstest.config.ts | New Rstest configuration file with equivalent test settings |
| package.json | Updated dependencies and test script to use Rstest |
| scripts/test-helper/rstest.setup.ts | Updated expect import to use @rstest/core |
| Multiple test files | Updated imports from 'vitest' to '@rstest/core' and mocking syntax |
| Snapshot files | Updated snapshot headers from Vitest to Rstest format |
| GitHub workflow files | Updated workflow names to reflect Rstest usage |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| import { defineConfig } from '@rstest/core'; | ||
|
|
||
| // Disable color in test | ||
| process.env.NO_COLOR = '1'; |
There was a problem hiding this comment.
The FORCE_COLOR environment variable that was set to '0' in the original vitest.workspace.ts is missing. This inconsistency might affect color output behavior in tests.
Suggested change
| process.env.NO_COLOR = '1'; | |
| process.env.NO_COLOR = '1'; | |
| process.env.FORCE_COLOR = '0'; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use Rstest as Rspress's test framework.
Related Issue
Checklist