-
-
Notifications
You must be signed in to change notification settings - Fork 213
feat: theme refactor #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: theme refactor #2533
Conversation
eeb126d
to
3865e65
Compare
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive theme refactor for the Rspress documentation framework, modernizing the UI with improved styling, better component organization, and enhanced functionality.
- Replaces Tailwind classes with CSS modules for better maintainability
- Refactors navigation bar with new dropdown components and improved layout
- Reorganizes code block components with separated concerns
- Adds progress tracking and scroll-to-top functionality to the sidebar
Reviewed Changes
Copilot reviewed 90 out of 95 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
website/docs/*/guide/basic/_meta.json | Adds "new" tag and collapsed state to MDX documentation |
packages/theme-default/src/styles/* | Updates CSS variables, color schemes, and component styling |
packages/theme-default/src/components/NewNav/* | New navigation component with dropdown menus and improved layout |
packages/theme-default/src/components/Sidebar/* | Refactored sidebar with modular components and dynamic state |
packages/theme-default/src/layout/DocLayout/docComponents/* | Reorganized MDX components with CSS modules |
packages/theme-default/src/components/Aside/* | Enhanced table of contents with progress tracking |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/theme-default/src/components/NewNav/NarTitle.tsx:1
- The filename 'NarTitle.tsx' contains a typo. It should be 'NavTitle.tsx' to match the exported component name.
import {
packages/shared/src/types/defaultTheme.ts:1
- The removal of 'enableScrollToTop' configuration option is a breaking change that should be documented. Consider adding a migration note or deprecation warning for users who were using this option.
export interface Config {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0f58439
to
48ea0a8
Compare
Summary
feat: theme refactor
Related Issue
Checklist