Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically approve/merge changes to interop-* labels #3954

Closed
foolip opened this issue Mar 16, 2023 · 5 comments · Fixed by #4105
Closed

Don't automatically approve/merge changes to interop-* labels #3954

foolip opened this issue Mar 16, 2023 · 5 comments · Fixed by #4105

Comments

@foolip
Copy link
Member

foolip commented Mar 16, 2023

In web-platform-tests/interop#288 I've created a workflow to ensure that there aren't unexpected changes to the set of tests in Interop 2023 and previous efforts.

@jgraham suggested that we instead prevent unexpected changes at the source, before they happen. We could do this by not approving or merging PRs to this repo if it changes the set of tests with an interop-* label, possibly excluding renames created by automated workflows.

@KyleJu do you think implementing this would be straightforward? Is there any CI step currently that compares the state of the repo before and after the change?

@KyleJu
Copy link
Contributor

KyleJu commented Mar 23, 2023

Added it to the backlog and hope to address it in Q2

@foolip
Copy link
Member Author

foolip commented Mar 24, 2023

Thanks Kyle!

@WeizhongX
Copy link

WeizhongX commented Apr 4, 2023

foolip@, I assume this will not have an impact to the exporter because we only meant to not auto merge to interop-* label? (Also this is wpt-metadata repo, first time see this.)

@foolip
Copy link
Member Author

foolip commented Apr 6, 2023

@WeizhongX right this will not affect import/export for the wpt repo.

@DanielRyanSmith
Copy link
Contributor

DanielRyanSmith commented Apr 11, 2023

Edit: This comment can be ignored. Kyle has a solution for handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants