-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't automatically approve/merge changes to interop-* labels #3954
Comments
Added it to the backlog and hope to address it in Q2 |
Thanks Kyle! |
foolip@, I assume this will not have an impact to the exporter because we only meant to not auto merge to interop-* label? (Also this is wpt-metadata repo, first time see this.) |
@WeizhongX right this will not affect import/export for the wpt repo. |
Edit: This comment can be ignored. Kyle has a solution for handling this. |
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In web-platform-tests/interop#288 I've created a workflow to ensure that there aren't unexpected changes to the set of tests in Interop 2023 and previous efforts.
@jgraham suggested that we instead prevent unexpected changes at the source, before they happen. We could do this by not approving or merging PRs to this repo if it changes the set of tests with an interop-* label, possibly excluding renames created by automated workflows.
@KyleJu do you think implementing this would be straightforward? Is there any CI step currently that compares the state of the repo before and after the change?
The text was updated successfully, but these errors were encountered: