Detect interop-* triage metadata #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2023 18:36
foolip
changed the title
foolip
approved these changes
Apr 27, 2023
| func containsInterop(metadata MetadataResults) bool { | ||
| for _, links := range metadata { | ||
| for _, link := range links { | ||
| if strings.Contains(link.Label, "interop") { |
There was a problem hiding this comment.
Just to call out the behavior, this will catch labels like interop-2023-has but also lets-go-interoperability that contain "interop" anywhere. That's OK I think.
There was a problem hiding this comment.
We actually have a number of assumptions around the repo that all labels containing interop are interop labels, so if it is ever the case that a new this-is-not-an-interop-label label is created, we'll need to reassess some logic. 🙂
There was a problem hiding this comment.
I am happy to tighten the logic in a follow-up PR!
DanielRyanSmith
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of web-platform-tests/wpt-metadata#3954. Add an "interop" PR label to metadata that is labelled "interop-*".
Staging Test
web-platform-tests/wpt-metadata#4104