Skip to content

Commit

Permalink
Fix leak in single-touch.html
Browse files Browse the repository at this point in the history
This test could trigger leak detection since not waiting on pointerup
after all of the async tests have completed.

Actions().send() does not wait on the dispatched events to be handled.
Each async test marked itself as done once the expected event was
received. Refactored to be a promise driven test.

2 flakes out of 100 runs without the fix.
0 flakes out of 500 runs with the fix.

Bug: 40945204
Change-Id: I5468e3bc67ecdfa5c09e53a705abdcbc22024cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033293
Commit-Queue: Kevin Ellis <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1386408}
  • Loading branch information
kevers-google authored and chromium-wpt-export-bot committed Nov 21, 2024
1 parent a0efcae commit 53c06dc
Showing 1 changed file with 345 additions and 303 deletions.
Loading

0 comments on commit 53c06dc

Please sign in to comment.