Skip to content

Commit

Permalink
Fix flaky wpt test external/wpt/longtask-timing/longtask-in-externals…
Browse files Browse the repository at this point in the history
…cript.html

Bug: 1377104
Change-Id: If49d9a286ba9691304477d48e80578c11c6d385b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3973567
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Sohom Datta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1062744}
  • Loading branch information
sohomdatta1 authored and chromium-wpt-export-bot committed Oct 24, 2022
1 parent 2fcf086 commit 96c4e12
Showing 1 changed file with 42 additions and 29 deletions.
71 changes: 42 additions & 29 deletions longtask-timing/longtask-in-externalscript.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,37 +10,50 @@
<h1>Long Task: External Script</h1>
<div id="log"></div>
<script>
async_test(function (t) {
assert_implements(window.PerformanceLongTaskTiming, 'Longtasks are not supported.');
promise_test(function(t) {
assert_implements(window.PerformanceLongTaskTiming, 'Longtasks are not supported.');
const performanceObserverTimeout = 5 * 1000;
const longTasksPromise = new Promise(resolve => {
const observer = new PerformanceObserver(
t.step_func(function (entryList) {
const entries = entryList.getEntries();
assert_equals(entries.length, 1,
'Exactly one entry is expected.');
const longtask = entries[0];
checkLongTaskEntry(longtask);
// Assert the TaskAttributionTiming entry in attribution.
assert_equals(longtask.attribution.length, 1,
'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerType, 'window');
assert_equals(attribution.containerId, '');
assert_equals(attribution.containerName, '');
assert_equals(attribution.containerSrc, '');
observer.disconnect();
t.done();
t.step_func(function(entryList) {
const entries = entryList.getEntries();
entries.forEach(longtask => {
assert_equals(longtask.entryType, 'longtask');
if (hasUnrelatedTaskName(longtask.name, 'self')) {
return;
}
checkLongTaskEntry(longtask);
// Assert the TaskAttributionTiming entry in attribution.
assert_equals(longtask.attribution.length, 1,
'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerType, 'window');
assert_equals(attribution.containerId, '');
assert_equals(attribution.containerName, '');
assert_equals(attribution.containerSrc, '');
observer.disconnect();
resolve();
})
);
observer.observe({entryTypes: ['longtask']});
window.onload = () => {
const script = document.createElement('script');
script.src = 'resources/makelongtask.js';
document.body.appendChild(script);
}
}));
observer.observe({
entryTypes: ['longtask']
});
const script = document.createElement('script');
script.src = 'resources/makelongtask.js';
document.body.appendChild(script);
});
const timeout = new Promise(
(resolve, reject) => t.step_timeout(
() => {
reject(new Error('observer failed to find any entries'))
},
performanceObserverTimeout)
)
return Promise.race([longTasksPromise, timeout]);
}, 'Performance longtask entries are observable.');
</script>
</body>

0 comments on commit 96c4e12

Please sign in to comment.