Skip to content

Commit

Permalink
[LayoutNG] Skip "replaced % resolution" quirk on ortho-roots.
Browse files Browse the repository at this point in the history
This is about an undocumented quirk. I raised
whatwg/quirks#46 for it.

LayoutNG currently cannot handle this situation, because we don't store
the inline-size to use in replaced percentage resolution (only the
block-size). However, I find it hard to believe that there'd be any
specific expectations to how this is supposed to work if a table cell
has a definite block-size, and a descendant establishes an orthogonal
writing-mode root. So just ignore it and use regular percentage size
resolution in these cases.

Bug: 967069
Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#670126}
  • Loading branch information
mstensho authored and Marcos Cáceres committed Jul 23, 2019
1 parent 739e8aa commit e1472e7
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions quirks/table-replaced-descendant-percentage-height-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!-- quirks mode -->
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://github.com/whatwg/quirks/issues/46">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=967069">
<div style="display:table-cell; height:10000px;">
<div style="writing-mode:vertical-rl;">
<iframe style="height:100%;"></iframe>
</div>
</div>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
test(()=> { }, "No crash");
</script>

0 comments on commit e1472e7

Please sign in to comment.