Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing done() in payment-handler/can-make-payment-event-construc… #11272

Closed
wants to merge 1 commit into from
Closed

Add missing done() in payment-handler/can-make-payment-event-construc… #11272

wants to merge 1 commit into from

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 31, 2018

…tor.https.worker.js

Part of #11269.

@zcorpan
Copy link
Member Author

zcorpan commented May 31, 2018

@rsolomakhin r?

@zcorpan zcorpan requested a review from marcoscaceres June 6, 2018 12:18
marcoscaceres
marcoscaceres approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@zcorpan zcorpan force-pushed the zcorpan/payment-handler-missing-done branch from da3e839 to c7198e1 Compare June 19, 2018 11:45
@zcorpan zcorpan force-pushed the zcorpan/payment-handler-missing-done branch from c7198e1 to f136dda Compare June 19, 2018 11:47
@zcorpan
Copy link
Member Author

zcorpan commented Jun 19, 2018

Looks like done() was added in 1dc612f#diff-0689e1a36239ee30dd9ede5a543f1856

@zcorpan zcorpan closed this Jun 19, 2018
@zcorpan zcorpan deleted the zcorpan/payment-handler-missing-done branch June 19, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
payment-handler wg-payments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @marcoscaceres @wpt-pr-bot