Run mypy for tools/serve/ (but still allow untyped defs) #28988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
commented
May 13, 2021
foolip
force-pushed
the
foolip/mypy-serve
branch
3 times, most recently
from
607d4da
to
349eb96
Compare
foolip
force-pushed
the
foolip/mypy-serve
branch
from
349eb96
to
85b070c
Compare
jgraham
approved these changes
Jun 11, 2021
|
|
||
| from localpaths import repo_root | ||
| from localpaths import repo_root # type: ignore |
There was a problem hiding this comment.
What's the error here? Seems like we should be able to mark this as a str.
There was a problem hiding this comment.
The error is "Cannot find implementation or library stub for module named 'localpaths'"
This kind of thing has come up in many places, and I'm thinking that perhaps together with web-platform-tests/rfcs#82 we could think of a path to having no sys.path meddling and having all imports resolve correctly for mypy, but I'm not sure now what it would entail.
Does that sound alarming, or does your review stand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28833.