Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable and fix wasm exceptions WPTs #36607

Merged
merged 1 commit into from
Oct 25, 2022
Merged

[wasm] Enable and fix wasm exceptions WPTs #36607

merged 1 commit into from
Oct 25, 2022

Commits on Oct 25, 2022

  1. [wasm] Enable and fix wasm exceptions WPTs 

    For most tests, expectations were deleted since the tests now pass.

The getArg test was corrected to match the spec:
https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg

The tag type test had its expectations updated, but is still
(incorrectly) failing because the test also depends on the not-yet-shipped
type reflection proposal. Updated the spec bug to bring this conversation
back to the spec (WebAssembly/exception-handling#172).

Bug: v8:11992
Change-Id: I979a9eb00219e0b9515d43bbeff6f80ac57df7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3972061
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1063368}
    @ajklein @chromium-wpt-export-bot
    ajklein authored and chromium-wpt-export-bot committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    e5e5a2c View commit details
    Browse the repository at this point in the history