Move some tests from toascii.json to urltestdata.json #38813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were introduced in e9a1061. However, these are not tests of the Unicode ToASCII algorithm. They are tests of the extra step introduced in whatwg/url@cceb435 to the URL Standard. Keep toascii.json focused on testing the ToASCII algorithm, so that software which implements it can use that file.
|
I agree with moving these tests from |
|
Now an idea came to mind: I think even better to move these tests to a new file, say /cc @annevk |
|
I think that might be reasonable, but I'm quickly reaching the limit of the extra effort I'm willing to put in here myself. I'm just trying to correct a bug so that my ToASCII library can be tested properly... |
rmisev
reviewed
Mar 6, 2023
| }, | ||
| { | ||
| "comment": "Empty host after domain to ASCII", | ||
| "input": "https://\u00AD/", |
There was a problem hiding this comment.
Add required base: parameter, the same for remaining two tests.
rmisev
suggested changes
Mar 6, 2023
rmisev
approved these changes
Mar 7, 2023
annevk
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were introduced in e9a1061. However, these are not tests of the Unicode ToASCII algorithm. They are tests of the extra step introduced in whatwg/url@cceb435 to the URL Standard.
Keep toascii.json focused on testing the ToASCII algorithm, so that software which implements it can use that file.
/cc @rmisev