-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update WAVE test runner #46286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FritzHeiden
wants to merge
16
commits into
web-platform-tests:master
Choose a base branch
from
FritzHeiden:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update WAVE test runner #46286
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
68510d6
feat: update wave test runner to current version
FritzHeiden 4f29487
style: remove comments
FritzHeiden 5eb798c
chore: revert changes in requirements.txt and tox.ini
FritzHeiden 259bc0c
fix: mypy annotations and future imports
FritzHeiden d3f5441
fix: wpt CI pipeline errors
FritzHeiden cba90c4
fix: flake8 errors
FritzHeiden b7c8fda
fix: tests not working with tox
FritzHeiden a4b7bc8
fix: untyped calls mypy error in wave-cli.py
FritzHeiden 8a67746
fix: remove unused tests
FritzHeiden 17f661e
fix: remove wave test integration
FritzHeiden fae3375
refactor: remove object parameter from class definitions
FritzHeiden 1c510d8
refactor: remove redundant io.open imports
FritzHeiden 626da2b
refactor: remove redundant super call paramters
FritzHeiden 2e6b51d
refactor: remove explicit u string declaration
FritzHeiden 4fc8eed
refactor: use f-strings
FritzHeiden 132d4fb
refactor: use property instead of index in urlsplit
FritzHeiden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # WMAS2017 ECMA Integration | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems very similar to https://github.com/web-platform-tests/wpt/issues/8308? |
||
|
|
||
| ## Generating Tests | ||
|
|
||
| Clone the ECMAScript 5 tests into the working directory | ||
|
|
||
| ``` | ||
| $ git clone [email protected]:tc39/test262.git -b es5-tests | ||
| ``` | ||
|
|
||
| Working directory should look like this | ||
|
|
||
| ``` | ||
| generate-tests.js | ||
| test262 | ||
| test-template.html | ||
| webplatform-adapter.js | ||
| ``` | ||
|
|
||
| Generate the tests by running | ||
|
|
||
| ``` | ||
| $ node generate-tests.js | ||
| ``` | ||
|
|
||
| Generated tests are placed in `ecmascript` directory. Copy this | ||
| directory into the top level directory of the Web Platform Tests | ||
| hierarchy in order for the Web Platform Test Runner to run them. | ||
|
|
||
| ## Test generation parameters | ||
|
|
||
| ``` | ||
| $ node generate-tests.js < test262-repo-dir > < output-dir > | ||
| ``` | ||
|
|
||
| You can specify where the test262 repository is located and where the | ||
| generated tests should be put in by passing the paths to the | ||
| generator script as shown above. | ||
|
|
||
| ## Excluded tests | ||
|
|
||
| The following tests are automatically excluded, because they are | ||
| causing the browser to freeze. | ||
|
|
||
| ``` | ||
| ch15/15.4/15.4.4/15.4.4.15/15.4.4.15-3-14.js | ||
| ch15/15.4/15.4.4/15.4.4.18/15.4.4.18-3-14.js | ||
| ch15/15.4/15.4.4/15.4.4.20/15.4.4.20-3-14.js | ||
| ch15/15.4/15.4.4/15.4.4.21/15.4.4.21-3-14.js | ||
| ch15/15.4/15.4.4/15.4.4.22/15.4.4.22-3-14.js | ||
| ``` | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to stop running the WAVE tests in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ci tests are incomplete and outdated. Therefore they serve no purpose in the ci.