Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (for now) tentative accname tests conflicting with current spec #49214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Nov 17, 2024

This change drops two subtests from the test at accname/name/comp_name_from_content.tentative.html.

Gecko, WebKit, and Chromium all fail those, and the tests don’t conform to the current spec requirements, nor to any WIP PR for changing the spec requirements. And there seems to have been no indication so far from Gecko, WebKit, or Chromium that they’re interested in implementing the change that’d be required to get their implementations passing.

So let’s remove them for now. If circumstances change, we can add them back later.

Note

I’m implementing accname support in Ladybird, and I don’t have any strong opinion at all about whether the spec should be updated to require the behavior that these tests expect.

If any of Gecko, WebKit, and Chromium showed some interest in implementing the behavior expected by these tests, then I’d also happily implement it. But in the mean time, rather than keeping those tests (and the failures for them) hanging around indefinitely, it seems better at this point to remove them for now.

I’m aware of the issue at w3c/accname#209 that discusses whether the spec requirements should be changed to match the behavior expected by these tests — but I notice that there hasn’t been any resolution on that issue, and there hasn’t even been any discussion in that issue for more than a year now.

So again — given all that — rather than keeping the tests and the failures for them hanging around indefinitely, it seems better at this point to remove them for now.

This change drops two subtests from the tentative accname test at
accname/name/comp_name_from_content.tentative.html. Gecko, WebKit, and
Chromium all fail those, and the tests don’t conform to the current spec
requirements, nor to any WIP PR for changing the spec requirements. And
there seems to have been no indication so far from Gecko, WebKit, or
Chromium that they’re interested in implementing the change that’d be
required to get their implementations passing those tests.

So let’s remove them for now. If circumstances change, we can add them
back later.
@sideshowbarker
Copy link
Contributor Author

sideshowbarker commented Nov 17, 2024

@cookiecrook It’s occured to me that as an alternative to removing the tests, we could instead keep them — but change their expectations to match the actual results for the tests in existing implementations.

If you want me to do it that way instead, lemme know, and I’ll update the patch here in the PR branch to do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants