Remove (for now) tentative accname tests conflicting with current spec #49214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change drops two subtests from the test at
accname/name/comp_name_from_content.tentative.html
.Gecko, WebKit, and Chromium all fail those, and the tests don’t conform to the current spec requirements, nor to any WIP PR for changing the spec requirements. And there seems to have been no indication so far from Gecko, WebKit, or Chromium that they’re interested in implementing the change that’d be required to get their implementations passing.
So let’s remove them for now. If circumstances change, we can add them back later.
Note
I’m implementing accname support in Ladybird, and I don’t have any strong opinion at all about whether the spec should be updated to require the behavior that these tests expect.
If any of Gecko, WebKit, and Chromium showed some interest in implementing the behavior expected by these tests, then I’d also happily implement it. But in the mean time, rather than keeping those tests (and the failures for them) hanging around indefinitely, it seems better at this point to remove them for now.
I’m aware of the issue at w3c/accname#209 that discusses whether the spec requirements should be changed to match the behavior expected by these tests — but I notice that there hasn’t been any resolution on that issue, and there hasn’t even been any discussion in that issue for more than a year now.
So again — given all that — rather than keeping the tests and the failures for them hanging around indefinitely, it seems better at this point to remove them for now.