[wptrunner] Run --enable-sanitizer tests with their own executors
#49235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running non-crashtests with the crashtest executor likely doesn't provide high-fidelity coverage because the test completes on the `load` event by default. This means that code paths normally exercised after the `load` event aren't actually run under sanitization. Also, some tests require testdriver, which the crashtest executor doesn't implement yet, to progress. Now, simply run each test with its corresponding type's executor and suppress functional failures (i.e., not timeout or crash) at the end. This also simplifies the result coercion, which didn't interact correctly with web-platform-tests#47903. Tested locally: ```sh ./wpt run -y chrome infrastructure --metadata infrastructure/metadata --enable-sanitizer ```
wpt-pr-bot
added
infra
wptrunner
|
https://crrev.com/c/6024228 will make a corresponding change downstream to ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running non-crashtests with the crashtest executor likely doesn't provide high-fidelity coverage because the test completes on the
loadevent by default. This means that code paths normally exercised after theloadevent aren't actually run under sanitization. Also, some tests require testdriver, which the crashtest executor doesn't implement yet, to progress.Now, simply run each test with its corresponding type's executor and suppress functional failures (i.e., not timeout or crash) at the end. This also simplifies the result coercion, which didn't interact correctly with #47903.
Tested locally: