Add Last-Event-ID to CORS-safelisted headers
#49257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
annevk
reviewed
Nov 19, 2024
The EventSource API does _not_ run any preflight request when specifying the `Last-Event-ID` header, and so `fetch` requests should also allow this header to be set manually. See whatwg/fetch#568 for more information
rexxars
force-pushed
the
fetch-cors-safelist-last-event-id
branch
from
746a146
to
79c1fed
Compare
Makes sense - added in c80e8b3 |
rexxars
force-pushed
the
fetch-cors-safelist-last-event-id
branch
from
79c1fed
to
c80e8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EventSource API does not run any preflight request when specifying the
Last-Event-IDheader, and sofetchrequests should also allow this header to be set manually.See issue whatwg/fetch#568 for more information and PR whatwg/fetch#1788 for changes to the specification