Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add tests of events for customizable select" #49279

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This is a reland of commit 86eb111c7cd216df5bc6e896256795e420d1bf99

The original patch is listed in patchset 1. The failures were caused by flakiness in the failure mode in two cases:

  1. The two virtual suites. Other similar failures for other tests
    are listed in TestExpectations, so this patch now does that.
  2. On linux, test_driver.bless() seems flaky (crbug.com/379669748).
    This patch disables this new test on Linux.

Original change's description:

Add tests of events for customizable select

This adds a test that looks at the event behavior of select,
particularly for interactions that open and close the picker,
and select options.

Change-Id: I5238360cecc83b48b0f8143380018d4781d65c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006480
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1383214}

Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51

Bug: 379669748
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Fixed: 379168836
Reviewed-on: https://chromium-review.googlesource.com/6032572
WPT-Export-Revision: b2ccd0a00ca08b743650c5759f6c2354262a9f4e

This is a reland of commit 86eb111c7cd216df5bc6e896256795e420d1bf99

The original patch is listed in patchset 1. The failures were caused by flakiness in the failure mode in two cases:
 1. The two virtual suites. Other similar failures for other tests
    are listed in TestExpectations, so this patch now does that.
 2. On linux, test_driver.bless() seems flaky (crbug.com/379669748).
    This patch disables this new test on Linux.

Original change's description:
> Add tests of events for customizable select
>
> This adds a test that looks at the event behavior of select,
> particularly for interactions that open and close the picker,
> and select options.
>
> Change-Id: I5238360cecc83b48b0f8143380018d4781d65c72
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006480
> Commit-Queue: Joey Arhar <[email protected]>
> Reviewed-by: Joey Arhar <[email protected]>
> Auto-Submit: Mason Freed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1383214}

Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51

Bug: 379669748
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Fixed: 379168836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants