Enable additional encoding tests in ShadowRealms #49286
Open
+112
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TextDecoder test can run in other scopes, because TextDecoder is exposed everywhere.
This test can be run in multiple scopes.
This is an alternative that doesn't require using MessageChannel, which is not exposed everywhere.
These seem to have been missed in web-platform-tests#41968. Includes ensuring that exports from any support files are defined on the global object, and that support scripts are referred to with their absolute paths from the root.
ptomato
commented
Nov 20, 2024
| @@ -1,6 +1,6 @@ | |||
| // META: timeout=long | |||
| // META: title=Encoding API: Fatal flag for single byte encodings | |||
| // META: timeout=long | |||
There was a problem hiding this comment.
This might look odd at first glance. META: timeout=long was listed twice.
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #41968. Enables the rest of the TextEncoder, TextDecoder, TextEncoderStream, and TextDecoderStream test coverage inside ShadowRealm scopes.