[Blink] Propagate lang attribute changes to child elements #49297
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible for elements to know if the lang attribute has changed for one of its ancestors. This change propagates lang attribute updates down the tree. The Permission Element listens to this change and updates the text accordingly. Bug: 374677445 Change-Id: Ic41c90a13f3fbb1faecc8298993bc74cb185137e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible for elements to know if the lang attribute has
changed for one of its ancestors. This change propagates lang attribute
updates down the tree.
The Permission Element listens to this change and updates the text
accordingly.
Bug: 374677445
Change-Id: Ic41c90a13f3fbb1faecc8298993bc74cb185137e
Reviewed-on: https://chromium-review.googlesource.com/6003767
WPT-Export-Revision: 3e22200e8e534a14ca43b1de321e02d622deadfa