Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Blink's test case for fallback handling of paint servers to WPT #50603

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Ahmad-S792
Copy link
Contributor

Hi Team,

While looking into SVG failures in WebKit, I noticed following tests, which could benefit from being on WPT. I asked for explicit approval from Fredrik Söderqvist (author of these tests) and now uploading them on WPT.

These are in relation to following Blink / Chromium PRs:

Commits:
https://source.chromium.org/chromium/chromium/src/+/a06aaf2d26a09493ed64b542baa29278a671425e , https://source.chromium.org/chromium/chromium/src/+/9ba199165cab706b90519a681f67ecce92241d5d and https://source.chromium.org/chromium/chromium/src/+/8a0b30e1432898d243c79bab84b373243edb97f2

Happy to fix any issue or error with guidance.

Thanks!

Hi Team,

While looking into SVG failures in WebKit, I noticed following tests,
which could benefit from being on WPT. I asked for explicit approval
from Fredrik Söderqvist (author of these tests) and now
uploading them on WPT.

These are in relation to following Blink / Chromium PRs:

Commits:
https://source.chromium.org/chromium/chromium/src/+/a06aaf2d26a09493ed64b542baa29278a671425e , https://source.chromium.org/chromium/chromium/src/+/9ba199165cab706b90519a681f67ecce92241d5d and https://source.chromium.org/chromium/chromium/src/+/8a0b30e1432898d243c79bab84b373243edb97f2

Happy to fix any issue or error with guidance.

Thanks!
@Ahmad-S792 Ahmad-S792 merged commit df03af4 into master Feb 10, 2025
19 checks passed
@Ahmad-S792 Ahmad-S792 deleted the fall-back-handling-svg-paint-servers branch February 10, 2025 13:18
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 11, 2025
They were exported to WPT in [1] and imported in [2].

[1] web-platform-tests/wpt@df03af4 /
    web-platform-tests/wpt#50603
[2] <commit-hash>

Fixed: 395489599
Change-Id: I9524deccd9e0770189855a93f616ad4c5e53566e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249019
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1418655}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants