-
Notifications
You must be signed in to change notification settings - Fork 3.6k
classify scroll-behavior #56467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classify scroll-behavior #56467
Conversation
gnarf
commented
Dec 3, 2025
5c3266d to
74729c9
Compare
|
Anyone have any idea why this PR keeps failing the |
d53b744 to
702af8b
Compare
Nothing in the failure log looks like it's plausibly caused by these changes. Sometimes things accidentally break on master and a rebase is required for a PR to get out of the bad state. Can you rebase and force push this? |
foolip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that these tests aren't in css/css-overflow/, but this seems right. I'll edit the patterns a bit though since the files are all scroll-behavior-*.
zainudinmuji4-commits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/spelling2.yml
@gnarf At first, I thought it was simply flaky. I tried it three more times, but it failed consistently. Then, I thought that it might be based on a faulty commit in the main development branch, but it failed after merging in the latest revision. My latest theory is that it's somehow balking at permissions (either in GitHub or in TaskCluster) for your account. That's why I squashed, rebased, and submitted a new pull request with a single commit that lists you as the committer and me as the author. That actually works. I'm not in a position to investigate TaskCluster any more deeply, so I'm going to merge that pull request, close this one, and move on. |