Skip to content

Conversation

@sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Dec 17, 2025

Addressing #56985.

The events were duplicated, as the same Webdriver BiDi session has multiple event processors, causing testdriver.js notified about the same event several times. Fixed by setting up events forwarding only on test setup.

Failure example: https://github.com/web-platform-tests/wpt/pull/56779/checks?check_run_id=58288772050

@sadym-chromium sadym-chromium enabled auto-merge (squash) December 17, 2025 11:06
@sadym-chromium sadym-chromium force-pushed the sadym/robustSubscriptionTest branch from 7f8075a to a17f552 Compare December 17, 2025 13:04
@sadym-chromium sadym-chromium marked this pull request as draft January 9, 2026 14:15
@sadym-chromium sadym-chromium force-pushed the sadym/robustSubscriptionTest branch from a17f552 to 70f2816 Compare January 9, 2026 14:23
@sadym-chromium sadym-chromium force-pushed the sadym/robustSubscriptionTest branch from 70f2816 to 424d75a Compare January 9, 2026 14:25
@sadym-chromium sadym-chromium force-pushed the sadym/robustSubscriptionTest branch from 4feb122 to ea356a2 Compare January 9, 2026 21:03
@sadym-chromium sadym-chromium force-pushed the sadym/robustSubscriptionTest branch from ea356a2 to 9184684 Compare January 9, 2026 21:03
@sadym-chromium sadym-chromium marked this pull request as ready for review January 9, 2026 22:03
@wpt-pr-bot wpt-pr-bot added the wptrunner The automated test runner, commonly called through ./wpt run label Jan 9, 2026
…y moving event listener registration to `setup` and using an instance variable for async exceptions.
@sadym-chromium sadym-chromium changed the title Robust infrastructure/testdriver/bidi/subscription.html test Fix Webdriver BiDi events duplication Jan 12, 2026
@sadym-chromium sadym-chromium enabled auto-merge (squash) January 12, 2026 11:30
@sadym-chromium sadym-chromium merged commit 34c421c into master Jan 12, 2026
50 checks passed
@sadym-chromium sadym-chromium deleted the sadym/robustSubscriptionTest branch January 12, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra wptrunner The automated test runner, commonly called through ./wpt run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants