[Gecko Bug 1981345] Implement referenceTarget support for multiple element attributes. #56915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split `GetAttrAssociatedElements()` into `Internals` and `ForBindings` versions; the latter returns the shadow host(s) rather than an element inside shadow DOM - Use `GetAttrAssociatedElementsInternal()` in `a11y::AssociatedElementsIterator`, removing the need for `AssociatedElementsIterator` to directly parse IDs or distinguish between ID-based or explicitly-set attr-associated elements. - This required an update to `DocAccessible`'s `AddDependentIDsFor()` method which previously used `AssociatedElementsIterator`'s `NextID()` method, which is removed in this patch. `AddDependentIDsFor()` now uses the parsed attribute directly instead. - In order to run the WPT tests which test `aria-labelledby` integration with `referenceTarget`, a new mechanism for retrieving elements inside shadow roots is added. This adds a `element_by_selector_array` action, which takes an array of selectors to be used successively from a document root to retrieve a shadow host, and then within the shadow host to retrieve the next shadow host, until the final selector returns the desired element. Differential Revision: https://phabricator.services.mozilla.com/D261366 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981345 gecko-commit: 32733496a5effaeedff3c8d7011586e4f38be7d7 gecko-reviewers: dom-core, Jamie, smaug
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Dec 24, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Contributor
|
Could someone from @web-platform-tests/admins force merge this PR? 🙏🏻 The infra failure in Chrome is not related to these changes, see #56985. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetAttrAssociatedElements()intoInternalsandForBindingsversions; the latter returns the shadow host(s) rather than an element inside shadow DOMGetAttrAssociatedElementsInternal()ina11y::AssociatedElementsIterator, removing the need forAssociatedElementsIteratorto directly parse IDs or distinguish between ID-based or explicitly-set attr-associated elements.DocAccessible'sAddDependentIDsFor()method which previously usedAssociatedElementsIterator'sNextID()method, which is removed in this patch.AddDependentIDsFor()now uses the parsed attribute directly instead.aria-labelledbyintegration withreferenceTarget, a new mechanism for retrieving elements inside shadow roots is added. This adds aelement_by_selector_arrayaction, which takes an array of selectors to be used successively from a document root to retrieve a shadow host, and then within the shadow host to retrieve the next shadow host, until the final selector returns the desired element.Differential Revision: https://phabricator.services.mozilla.com/D261366
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981345
gecko-commit: 32733496a5effaeedff3c8d7011586e4f38be7d7
gecko-reviewers: dom-core, Jamie, smaug