[Origin API] Add more test coverage for opaque origin comparison

[shannonbooth]

cc @mikewest @annevk

Relating to whatwg/url#892 and whatwg/html#12058

One case which I didn't figure out a nice way of covering is opaque origin Worker which is not a data scheme URL

[shannonbooth]

I pushed another commit to remove the file scheme URL test, as that has implementation defined behavior (discovered playing around making it not a tuple origin). Though actually, as I write this, maybe a test should instead be in a different file checking that:

const fileSchemeIsOpaque = new URL('file:///something/').origin === 'null' ;
assert_eq(fileSchemeIsOpaque, Origin.from('file:///something/').opaque);

[annevk]

These are great @shannonbooth, thanks for writing them! I'll see if I need to change WebKit in a minute.

For file: URLs it seems reasonable to add .tentative test expecting an opaque origin.

I was hoping at some point we could at least agree that file: URL origins would always serialize as "null", but that didn't work out, but it might be time to try again.

[shannonbooth]

For file: URLs it seems reasonable to add .tentative test expecting an opaque origin.

I was hoping at some point we could at least agree that file: URL origins would always serialize as "null", but that didn't work out, but it might be time to try again.

Sure, added a tentative test to check that a file URL has an opaque origin. I'm not certain if the same origin behavior would tentatively be the same as all other opaque origin schemes, but I also added tests for that.

FWIW I am trying to make progress on moving towards opaque file origins in ladybird (LadybirdBrowser/ladybird#7309 makes file origins opaque by default) to try and move closer to match other browsers behavior / security etc. The main point of investigation I have for this at the moment is on how to handle file scheme URLs in fetch, so hopefully I might be able to help making progress on whatwg/fetch#1195 depending on how far I manage to progress 😄

[annevk]

Looks good modulo nit. Thanks again!

[mikewest]

LGTM too. I have small nits to improve clarity, but neither is important.