webdriver: Fix outdated timeouts test and remove redundant check #56959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 2, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
whimboo
requested changes
Jan 2, 2026
| {"implicit": 0, "pageLoad": 300000,"script": 444}, | ||
| {"implicit": 0, "pageLoad": None,"script": 30000}, | ||
| {"implicit": None, "pageLoad": 300000,"script": 444}, | ||
| {"implicit": 0, "pageLoad": 300000,"script": None}, |
Contributor
There was a problem hiding this comment.
It would be better to have multiple paramerizations like the following to cover all valid cases for each timeout type:
@pytest.mark.parametrize("value", [None, 0, 3000])
@pytest.mark.parametrize("key", ["implicit", "pageLoad", "script")
| {"implicit": None, "pageLoad": None,"script": None} | ||
| {"implicit": None, "pageLoad": MAX_SAFE_INTEGER + 2,"script": 30000}, | ||
| {"implicit": MAX_SAFE_INTEGER + 2, "pageLoad": None,"script": 30000}, | ||
| {"implicit": None, "pageLoad": None,"script": MAX_SAFE_INTEGER + 2} |
Contributor
There was a problem hiding this comment.
I think that we can simplify the test as well and only have the invalid case.
servo-wpt-sync
force-pushed
the
servo_export_41631
branch
from
ee883f0 to
96c0a8b
Compare
whimboo
reviewed
Jan 2, 2026
| ]) | ||
| def test_invalid_timeouts(new_session, add_browser_capabilities, timeouts): | ||
| response, _ = new_session({"capabilities": {"alwaysMatch": add_browser_capabilities({"timeouts": timeouts})}}) | ||
| @pytest.mark.parametrize("value", [MAX_SAFE_INTEGER + 1, -11]) |
Contributor
There was a problem hiding this comment.
Any negative integer should cause a failure. So please use the closest number as possible.
Suggested change
| @pytest.mark.parametrize("value", [MAX_SAFE_INTEGER + 1, -11]) | |
| @pytest.mark.parametrize("value", [MAX_SAFE_INTEGER + 1, -1]) |
servo-wpt-sync
force-pushed
the
servo_export_41631
branch
from
96c0a8b to
0cc4642
Compare
whimboo
reviewed
Jan 5, 2026
| response, _ = new_session({"capabilities": {"alwaysMatch": add_browser_capabilities({"timeouts": timeouts})}}) | ||
| @pytest.mark.parametrize("value", [MAX_SAFE_INTEGER + 1, -1]) | ||
| @pytest.mark.parametrize("key", ["implicit", "pageLoad", "script"]) | ||
| def test_invalid_timeouts(new_session, add_browser_capabilities, key, value): |
Contributor
There was a problem hiding this comment.
Looks good to me. Bonus points if we could name this method test_invalid_timeout_value and have another test with test_invalid_timeout_type where we specify false, "foo", [], {} as parameters.
servo-wpt-sync
force-pushed
the
servo_export_41631
branch
from
0cc4642 to
0222494
Compare
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41631
branch
from
0222494 to
9bee018
Compare
yezhizhen
reviewed
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the attempt is to validate params according to spec. But it turns out validation is already done at webdriver crate so I reverted the change.
But Chrome/Firefox are not compliant with spec: https://wpt.fyi/results/webdriver/tests/classic/new_session/timeouts.py?label=experimental&label=master&aligned. They only allow
script timeoutsto beNonebut notpageLoadandimplicit, which is how the test is currently written.Testing: Updated the test to be compliant with spec. New failures are because it is validated at webdriver crate.
Reviewed in servo/servo#41631