Add webExtension runtime.getVersion() test
#56993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
oliverdunk
reviewed
Jan 6, 2026
| async function browserRuntimeGetVersion() { | ||
| const version = browser.runtime.getVersion(); | ||
| browser.test.assertEq(typeof version, "string"); | ||
| browser.test.assertTrue(version === "1.01" || version === "1.1"); |
Contributor
There was a problem hiding this comment.
Should we add a comment that explains that leading zeroes are handled differently across browsers?
Author
There was a problem hiding this comment.
Ideally we would have runtime.getVersion() specified somewhere with a note the version number is up for interpretation by the implementation but has to be consistent with other APIs (like the management API).
We may want to make the version validator more strict in mv4, see w3c/webextensions#878 (comment)
Edit: updated the PR with a comment.
carlosjeurissen
force-pushed
the
feat/web-extensions/runtime-get-version
branch
from
c6058de to
f6fb547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliverdunk made sure to also consider the different interpretation of the version by Chromium as discussed in w3c/webextensions#878. The check also compares the version from
management.getSelf()withruntime.getVersion()as intended by Chromium.@kiaraarose since this is very early in the wpt process for webExtensions, switched to semicolons and double space as that seems to be most common for js in wpt tests. However, happy to revert back.
@zombie FYI