Skip to content

Reland "[soft navs] Refactor pending ICP entry buffering" #56996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Jan 5, 2026
Merged

Reland "[soft navs] Refactor pending ICP entry buffering" #56996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion soft-navigation-heuristics/smoke/tentative/late-url-change.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
const URL = '/late-url-change';

navigateButton.addEventListener("click", async () => {
content.innerHTML = '<img src="/images/lcp-256x256.png" elementtiming="test-image"></img>';
content.innerHTML = '<img id="target" src="/images/lcp-256x256.png" elementtiming="test-image"></img>';

const entries = await new Promise(resolve => {
new PerformanceObserver((list, observer) => {
Expand All @@ -31,6 +31,8 @@

const softNavPromise =
SoftNavigationTestHelper.getPerformanceEntries("soft-navigation");
const icpPromise =
SoftNavigationTestHelper.getPerformanceEntries("interaction-contentful-paint");

if (test_driver) {
test_driver.click(navigateButton);
Expand All @@ -43,5 +45,10 @@
assert_true(
entries[0].name.endsWith(URL),
'Unexpected Soft Navigation URL.');

const icps = await helper.withTimeoutMessage(
icpPromise, 'ICP not detected.', /*timeout=*/ 3000);
assert_equals(icps.length, 1, 'Expected exactly one ICP entry.');
assert_equals(icps[0].id, 'target', 'Expected ICP candidate to be "target"');
}, 'Soft Navigation Detection supports setting URL after paint');
</script>