Update to support Python 3.14 #57004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the only place we're running an async client in the main thread, so we can just create an event loop here
These are open file handles and with Python3.14 we're getting a warning if they are closed in the destructor.
Python 3.14 seems to have movved to forkserver as the default, so these tests are broken there, as they are with 'spawn'
jsonschema started warning when it's auto-resolving references, so we instead pre-download the expected references and create a registry.
wpt-pr-bot
added
Azure Pipelines
ci
infra
manifest
requirements_mypy.txt
requirements_tests.txt
tox.ini
webtransport
wg-s_webtransport
wpt
wptrunner
wpt-pr-bot
requested review from
DanielRyanSmith,
bashi,
foolip,
jonathan-j-lee and
nidhijaju
foolip
approved these changes
Jan 8, 2026
| with self.assertRaises(urllib.error.HTTPError): | ||
| with self.assertRaises(urllib.error.HTTPError) as cm: | ||
| self.request("/sub_file_hash_unrecognized.sub.txt") | ||
| cm.exception.close() |
Contributor
Author
There was a problem hiding this comment.
No! Weirdly it doesn't work if you try to close the exception (file) inside the context manager.
Member
There was a problem hiding this comment.
That is weird, but thanks for confirming :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.