Skip to content

Fix potential false positives in invalid-element-types command test #57031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukewarlow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential false positives in invalid-element-types command test #57031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions html/semantics/the-button-element/command-and-commandfor/invalid-element-types.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,24 @@
<script src="resources/invoker-utils.js"></script>
<script src="/html/resources/common.js"></script>

<meta name=variant content=?command=--custom-event&half=first>
<meta name=variant content=?command=--custom-event&half=second>
<meta name=variant content=?command=show-popover&half=first>
<meta name=variant content=?command=show-popover&half=second>
<meta name=variant content=?command=show-modal&half=first>
<meta name=variant content=?command=show-modal&half=second>
<meta name=variant content=?command=--custom-event&half=first&target=divinvokee>
<meta name=variant content=?command=--custom-event&half=second&target=divinvokee>
<meta name=variant content=?command=show-popover&half=first&target=popoverinvokee>
<meta name=variant content=?command=show-popover&half=second&target=popoverinvokee>
<meta name=variant content=?command=show-modal&half=first&target=dialoginvokee>
<meta name=variant content=?command=show-modal&half=second&target=dialoginvokee>

<div id="invokee"></div>
<div id="divinvokee"></div>
<div id="popoverinvokee" popover></div>
<dialog id="dialoginvokee"></dialog>

<script>
// The command parameter is provided by variants, to
// effectively split this (slow) test into multiple runs.
const urlParams = new URLSearchParams(window.location.search);
command = urlParams.get('command');
half = urlParams.get('half');
const command = urlParams.get('command');
const target = urlParams.get('target');
const half = urlParams.get('half');
const firstHalf = half === 'first';
assert_true(firstHalf || half === 'second');

Expand All @@ -34,12 +37,12 @@
const midpoint = Math.floor(allTags.length / 2);
const tags = firstHalf ? allTags.slice(0,midpoint) : allTags.slice(midpoint);
let gotEvent = false;
invokee.addEventListener('command',() => (gotEvent = true));
document.getElementById(target).addEventListener('command',() => (gotEvent = true));
for(const tag of tags) {
promise_test(async () => {
gotEvent = false;
const element = document.createElement(tag);
element.setAttribute('commandfor','invokee');
element.setAttribute('commandfor',target);
element.setAttribute('command',command);
element.style.display = 'block'; // For normally invisible elements
document.body.appendChild(element);
Expand Down