wpt: Parse run_log as url_or_path
#57036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <[email protected]>
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Jan 7, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Contributor
|
The failure seems irrelevant. |
jgraham
approved these changes
Jan 12, 2026
Contributor
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
I mean OK, but this is clearly going to break if you pass a URL into any non-servo implementation because they all expect that they're getting a path, not a URL.
It's a bit bureaucratic, but the process here should really have been to create an RFC to allow passing in URLs, and to at least update the default wptrunner implementation to support URLs, rather than just changing servo code to support URLs, and then updating the frontend to match servo's extensions without considering other consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we parse it as https://github.com/servo/servo/blob/c6f2fc2eb596cd2cd581179113bbceda301c4c93/tests/wpt/tests/tools/wptrunner/wptrunner/wptcommandline.py#L17-L18. This appends CWD to the front even if we pass a URL.
Fixes: servo/servo#41728
Reviewed in servo/servo#41729