[carousel] Avoid nullptr ::column computed style. #57052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that ::column pseudo-elements always store computed style. Checking display type here was wrong, since ::column pseudo-elements never create layout boxes. If a `::column` became `display:none`, its computed style would be set to null, which in turn would crash somewhere. In the crash test included it would crash in Element::GetOrCreateColumnPseudoElementIfNeeded() because of this. This is a speculative fix for http://crbug.com/470512590 Big thanks to futhark for help with analyzing and advice! Bug: 470512590 Change-Id: I7b62ab9c77dd6a7529415a7f2e721696d84ab25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7362160 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1566152}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7362160
branch
from
4fa003a to
7a818c7
Compare
wpt-pr-bot
approved these changes
Jan 8, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that ::column pseudo-elements always store computed style.
Checking display type here was wrong, since ::column pseudo-elements
never create layout boxes. If a
::columnbecamedisplay:none, itscomputed style would be set to null, which in turn would crash
somewhere. In the crash test included it would crash in
Element::GetOrCreateColumnPseudoElementIfNeeded() because of this.
This is a speculative fix for http://crbug.com/470512590
Big thanks to futhark for help with analyzing and advice!
Bug: 470512590
Change-Id: I7b62ab9c77dd6a7529415a7f2e721696d84ab25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7362160
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1566152}