[Gecko Bug 2008625] Don't unconditionally fall back to single inserts for ::first-letter. #57068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the regression making us go through the same codepath as before, but I think this assertion is fishy, see details on the bug. Differential Revision: https://phabricator.services.mozilla.com/D278121 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008625 gecko-commit: 7c7cb9e2ce5c59179d9a0eed7f1dd31472c8a137 gecko-reviewers: TYLin, layout-reviewers
wpt-pr-bot
approved these changes
Jan 8, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression making us go through the same codepath as
before, but I think this assertion is fishy, see details on the bug.
Differential Revision: https://phabricator.services.mozilla.com/D278121
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008625
gecko-commit: 7c7cb9e2ce5c59179d9a0eed7f1dd31472c8a137
gecko-reviewers: TYLin, layout-reviewers