Reland "Make <menuitem> automatically be an interest invoker" #57113
+88
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4 The problem was that the addition of interest invoker behavior caused some tests (particularly ones that test focus navigation) to flakily activate menus while traversing focus. Patchset 3+ fixes that by explicitly setting the interest invoker delays accordingly. Original change's description: > Make <menuitem> automatically be an interest invoker > > If a menuitem is a submenu invoker, it automatically becomes > an interest invoker, so that hovering it opens the submenu. > > Fixed: 422216068 > Bug: 406566432 > Change-Id: I93b844dea7b4c321cdb6b148bae8654e73c90038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7276492 > Auto-Submit: Mason Freed <[email protected]> > Commit-Queue: Mason Freed <[email protected]> > Reviewed-by: David Baron <[email protected]> > Commit-Queue: David Baron <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1566675} Bug: 406566432, 422216068 Change-Id: Icec74709640f48a0110b52a51a2570f21176d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7425331 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Commit-Queue: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1567165}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7425331
branch
from
0a9f942 to
a6f95c3
Compare
wpt-pr-bot
approved these changes
Jan 9, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4
The problem was that the addition of interest invoker behavior
caused some tests (particularly ones that test focus navigation)
to flakily activate menus while traversing focus. Patchset 3+ fixes
that by explicitly setting the interest invoker delays accordingly.
Original change's description:
Bug: 406566432, 422216068
Change-Id: Icec74709640f48a0110b52a51a2570f21176d7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7425331
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1567165}