layout: Let floats know that margins can collapse thru phantom lines #57116
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 9, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
zainudinmuji4-commits
approved these changes
Jan 9, 2026
Phantom line boxes allow margins to collapse through them. But in the sequential layout state we were assuming that was not the case, so we were placing floats incorrectly. Signed-off-by: Oriol Brufau <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41812
branch
from
864fdb4 to
585dd5b
Compare
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#41812), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
auto-merge was automatically disabled
January 13, 2026 23:57
Pull request was closed
Loirooriol
force-pushed
the
servo_export_41812
branch
2 times, most recently
from
ac19357 to
585dd5b
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantom line boxes allow margins to collapse through them. But in the sequential layout state we were assuming that was not the case, so we were placing floats incorrectly.
Testing: Adding 2 tests
Fixes: #41794
Fixes: #41734
Reviewed in servo/servo#41812