Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[769] feat: enforce consent prompt in GitHub provider #778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prakash8999
Copy link

title: Issue #769 | Enforce consent prompt in GitHub provider

Discord Username: @

## What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

## Description

This PR updates the GitHub provider configuration by adding the prompt: "consent" parameter. With this change, users will now always see the authorization consent screen when they log in, even if they recently logged out. This fixes the issue where users were being automatically logged in without going through the authorization step again.
image

## Related Tickets & Documents

## QA Instructions, Screenshots, Recordings

  1. Log out from the app.
  2. Log back in using the GitHub provider.
  3. Verify that the authorization consent screen is displayed as expected.

### UI accessibility concerns?

N/A (No UI changes)

## Added/updated tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

## [optional] Are there any post-deployment tasks we need to perform?

No additional tasks required.

## [optional] What gif best describes this PR or how it makes you feel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Getting automatically logged in after log out
1 participant