Skip to content

Conversation

MalteWunsch
Copy link
Member

This is more helpful than the error thrown otherwise:

Error: Typed property Webfactory\Bundle\PolyglotBundle\Doctrine\PersistentTranslatable::$primaryValue must not be accessed before initialization

MalteWunsch and others added 2 commits September 17, 2025 17:23
…ocale

This is more helpful than the error thrown otherwise:
```
Error: Typed property Webfactory\Bundle\PolyglotBundle\Doctrine\PersistentTranslatable::$primaryValue must not be accessed before initialization
```
@MalteWunsch MalteWunsch requested a review from mpdude September 17, 2025 15:26
@MalteWunsch
Copy link
Member Author

The error message got a little bit verbose in the end, but in a way that would have helped me in different situations. I am however open for other messages as well.

I wondered how this change should be categorized in terms of semantic versioning. I think it only improves the message for an unavoidable error, so it does not break any new things => Bugfix seems to be appropriate for me. Agreed?

@MalteWunsch
Copy link
Member Author

Seems this change could make #50 more difficult (but I don't see this as a blocking issue).

@MalteWunsch MalteWunsch marked this pull request as ready for review September 17, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant