Chore: Connector puppeteer use lock only in detached mode

[sarvaje]

Fix #4089

Pull request checklist

Make sure you:

• Signed the Contributor License Agreement
• Followed the commit message guidelines

For non-trivial changes, please make sure you also:

• Added/Updated related documentation.
• Added/Updated related tests.

Short description of the change(s)

Detach mode is used mostly for the test runner, to avoid opening multiple instances of the browser. To do so, it store in disk the browser information of the first instance opened, so the next calls can reuse that information.

Before this PR, the writing/reading of the disk were done even if it wasn't running in detach mode.

This PR disables the writings to disk if we are not in detach mode. This will save some time accessing to disk, but more important, it will solve a problem running connector-puppeteer in Azure Functions Consumption plan.

Azure Function Consumption plan doesn't allow writing in the disk, except for the tmp folder, so this change is needed if we want to complete webhintio/serverless-online-service#143

[antross]

The changes look fine, but can you add a bit more detail explaining why this won't work in the consumption plan without this change, and why using the lock isn't necessary in that context? Thanks!

[sarvaje]

The changes look fine, but can you add a bit more detail explaining why this won't work in the consumption plan without this change, and why using the lock isn't necessary in that context? Thanks!

Do you mean in the code or in the PR?

[antross]

The changes look fine, but can you add a bit more detail explaining why this won't work in the consumption plan without this change, and why using the lock isn't necessary in that context? Thanks!

Do you mean in the code or in the PR?

I meant in the PR description. I figure we'll keep that around as part of the squashed commit comment too. Though now that you mention it, updating the existing code comment wouldn't hurt either 😉

[sarvaje]

@antross please take another look.

[antross]

LGTM, thanks!