-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-ui): IconPicker component #4519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/cli/files/references.json
adrians5j
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review done. Overall, looks good ofc!
Extra questions below. Note: nr2 is probably good.
- Should these be a bit darker?

- This input is more gray in Figma.

- Ah I guess it's because in Figma it's not focused. Still, found this placeholder to be a bit darker in Figma:

Maybe I just don't see it right. Can you dbl check?
- Can you dbl check these paddings?

- Should we ask Kreso to provide this? At least note it down somewhere for him?

- Do we have an example where a component does not already have a value assigned to it? Like this?
packages/admin-ui/src/IconPicker/primitives/IconPickerPrimitive.tsx
Outdated
Show resolved
Hide resolved
packages/app-admin/src/components/IconPicker/components/IconPickerTrigger.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we are upgrading the IconPicker component to ensure it complies with the new design system UI.
You'll find 2
IconPicker
components:webiny/admin-ui
This component was previously integrated into the
@webiny/app-headless-cms
and@webiny/app-page-builder
packages. Both of these components now utilize the generic version exported by@webiny/admin-ui
.This component only renders icons from
@fortawesome/react-fontawesome
package.webiny/app-admin
This component is utilised by
@webiny/app-page-builder
and is more flexible regarding which icons can be handled.Other changes:
<DelayedOnChange />
This component has been transferred from
@webiny/ui
to the fresh@webiny/admin-ui
.Add
forwardEventOnChange
prop to<Input />
and<Textarea />
We introduce the
forwardEventOnChange?: boolean
prop; if set to true, the full event will be forwarded to the providedonChange
callback. This prop was previously namedrawOnChange
.<Popover />
We set the
collisionPadding
prop to prevent the component from colliding with the edge of the viewport.How Has This Been Tested?
Manually