Update membership instead of remove + add chain #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
ivarnakken
changed the title
LudvigHz
approved these changes
Apr 19, 2023
norbye
approved these changes
Apr 27, 2023
ivarnakken
added
approved
By preserving the memberhsip, your position in the table will stay the same. Looks much better :)
ivarnakken
force-pushed
the
ivarnakken/aba-400-update-membership-instead-of
branch
from
7f23b49
to
162763d
Compare
|
Why does this have "do-not-merge/hold"? |
Because the backend is not fixed - had some issues with it. Wanted to change how memberships are created and used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By preserving the membership, your position in the table will stay the same. Looks much better :)
Backend change: webkom/lego#3301
Result
Screen.Recording.2023-04-17.at.21.13.30.mov
any real user information.
Testing
What you see above. Your position is not changed.