Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide banner #4936

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Hide banner #4936

merged 3 commits into from
Sep 15, 2024

Conversation

Bestem0r
Copy link
Contributor

@Bestem0r Bestem0r commented Sep 3, 2024

Description

Hide the banner since "opptaksperioden" is over.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Testing

  • I have thoroughly tested my changes.

Navigate to the front page and verify that the banner is hidden.

@Bestem0r Bestem0r requested a review from falbru September 3, 2024 09:27
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 7:08pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 3, 2024
@norbye
Copy link
Member

norbye commented Sep 3, 2024

Ey Ey Ey, revue is still recruiting

So if you want to change it, maybe rather change it to Abakusrevyen instead of Abakus

@Bestem0r Bestem0r added the do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged label Sep 3, 2024
@Bestem0r
Copy link
Contributor Author

Bestem0r commented Sep 3, 2024

Ey Ey Ey, revue is still recruiting

So if you want to change it, maybe rather change it to Abakusrevyen instead of Abakus

Whoops, completely forgot about that 😅! Consider this PR on hold then...

@norbye
Copy link
Member

norbye commented Sep 3, 2024

Ey Ey Ey, revue is still recruiting
So if you want to change it, maybe rather change it to Abakusrevyen instead of Abakus

Whoops, completely forgot about that 😅! Consider this PR on hold then...

image

@norbye norbye marked this pull request as draft September 3, 2024 09:45
@ivarnakken ivarnakken added the chore Pull requests that does something "boring", yet important, e.g. cleaning up code label Sep 3, 2024
@ivarnakken
Copy link
Member

@Bestem0r Perhaps prepare this for merge and deployment soon? 😄

@Bestem0r Bestem0r marked this pull request as ready for review September 15, 2024 19:06
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admissions end tonight, so deploying any time after midnight is gucci

Remember to squash merge this one

@Bestem0r Bestem0r merged commit a034480 into master Sep 15, 2024
4 of 5 checks passed
@Bestem0r Bestem0r deleted the hide-banner branch September 15, 2024 21:29
@Bestem0r
Copy link
Contributor Author

Hmm.. Looks like CI is broken. Rerunning previously good builds now fail. I merged this since it should be good in theory, but cannot deploy yet. Do you have any idea on how to fix CI? @ivarnakken @norbye

@norbye
Copy link
Member

norbye commented Sep 15, 2024

Hmm.. Looks like CI is broken. Rerunning previously good builds now fail. I merged this since it should be good in theory, but cannot deploy yet. Do you have any idea on how to fix CI? @ivarnakken @norbye

We're having some cache issues it seems.. I cleared the cache on CI and now it seems to run smoothly

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests that does something "boring", yet important, e.g. cleaning up code do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants