Set input font size to be 16px on mobile #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ivarnakken
force-pushed
the
font-size-input-on-mobile
branch
from
fbd6d45
to
84feebe
Compare
eikhr
approved these changes
Sep 14, 2024
ivarnakken
force-pushed
the
font-size-input-on-mobile
branch
10 times, most recently
from
d313194
to
b59e15f
Compare
For some dumb reason, any inputs with a smaller font size than `16px` will cause the browser on mobile (I think only Safari) to "zoom" in on the field. On the event registration modal, this causes annoying bugs when trying to search for attendees.
ivarnakken
force-pushed
the
font-size-input-on-mobile
branch
from
b59e15f
to
4a6f491
Compare
ivarnakken
force-pushed
the
font-size-input-on-mobile
branch
5 times, most recently
from
5991fdf
to
4a6f491
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some dumb reason, any inputs with a smaller font size than
16pxwill cause the browser on mobile (I think only Safari) to "zoom" in on the field when focusing on it. On the event registration modal, this causes annoying bugs when trying to search for attendees.Read more here.
Testing
Not actually tested, other than that I have confirmed that the font-size is
16pxon mobile viewports.Resolves ABA-1068