Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: Future improvements #629

Open
iliajie opened this issue Jan 3, 2017 · 110 comments
Open

File Manager: Future improvements #629

iliajie opened this issue Jan 3, 2017 · 110 comments
Assignees

Comments

@iliajie
Copy link
Collaborator

iliajie commented Jan 3, 2017

To make new File Manager shinier we need to add:

  1. Manage symbolic links - added on 19.20-beta5 (October 03, 2018) File Manager: Future improvements #629 (comment)
  2. Extend search with ability to specify user and group, file type (file, directory, symlink) - added on 19.70-beta2 (December 24, 2020) 4ee8d65

To make it more powerful and comfortable to use, lets add some extra functionality:

  1. Ability to diff two files File Manager: Enroll support for diffing #612

  2. Movable and resizeable editor windows - added on 18.49 (May 18, 2017)

  3. Image viewer with simple editor functionality; audio and video player - added on 19.32 (April 28, 2019)

  4. Viewing archives content

  5. Ability to download directory - added on 19.14 (April 26, 2018) 9f114ac

  6. Selecting files/directories using wildcard

  7. Calculate and verify checksum of files - added

  8. Split and combine files

  9. Exclude from search given folders - _added on 19.38 (July 20, 2019)

  10. Multi-rename tool

  11. Add multiple uploads - added

  12. Add an option to automatically extract uploaded file(s) - added

  13. Edit/reorder bookmarks (not just delete/add)

  14. In File Manager, when extracting an archive, all files and folders gets root-root. In Java File Manager setting you can select the default user as "same as the directory". Or if you want to change you can do it in the upload dialog. And you also can select "Upload, Extract and Delete file" in one action. #52020 - added

  15. Tree-view - added on 19.10-beta1 (March 18, 2018) File Manager: Tree-view #1066

  16. QuillJS - HTML, rich text editor - added on 19.10-beta4 (February 28, 2018) Adding HTML editor to File Manager #1031

  17. Integrate Disk Usage module

  18. Add text conversion for text editor - added

  19. Add ability to reset column sorting File Manager: Ability to reset column sorting #1088 - _added on 19.38 (July 20, 2019)

  20. Abort current call, when clicking the other link - added on 19.13-beta2 (April 17, 2018) 3cdc3ec

  21. Add management for password protected archives Webmin file explorer rar files no extract option webmin#702 (comment) - added on 19.32 (April 28, 2019)

  22. Manage file-size calculations on client-side for already calculated directories File manager - calculate selected size #1136

  23. Add ACLs control Issue with File ALCs module #1229 (comment)

  24. Upload directories -- added

Anything else you miss/wish? Please comment below.

@iliajie
Copy link
Collaborator Author

iliajie commented May 14, 2017

Feature Movable and resizeable editor windows has been added to 18.49 release.

Added dropdown menu with yummy stuff for the editor.

  1. Align Panels Vertically (when the menu is opened hold Alt to see the magic happening. Besides holding Shift will reverse panels arrangement)
  2. Toggle Soft Wrap
  3. Refresh Content
  4. Help (moved away from the top)

screenshot from 2017-05-16 17-03-14

@iliajie
Copy link
Collaborator Author

iliajie commented May 16, 2017

f086f2a

@iliajie
Copy link
Collaborator Author

iliajie commented Oct 3, 2018

Added support for creating symbolic links in File Manager.

screenshot from 2018-10-03 15-08-32

@xulinbao
Copy link

Google Chrome can't load file manager. demo:https://www.scall.xyz/file.mp4 File management is always loading.

The Firefox browser loads the file manager normally.

Sometimes it is normal, very confused.

@iliajie
Copy link
Collaborator Author

iliajie commented May 10, 2019

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

@iliajie
Copy link
Collaborator Author

iliajie commented May 11, 2019

Did it solve your issue?

@sz00gun
Copy link

sz00gun commented May 14, 2019

If possible could you please fix better view on mobiles. Either menu more narrow or higher z-index for menu.
Schowek02

That's not bad:
Schowek03

@jonathanisodme
Copy link

Not sure if this is the right place, but I would like an option to edit file manager settings on filemin. It would be useful to be able to enable/disable the encrypt feature and some other features for the virtual server owners.

@iliajie
Copy link
Collaborator Author

iliajie commented May 20, 2019

@leijonathan It's better to open separate issue.

I don't understand what you mean. What do you mean enable/disable encrypt feature?

@qwrty-ftw
Copy link

qwrty-ftw commented Aug 1, 2019

Hello @rostovtsev

Do you have any ETA about the point number 23 ?

Thank you very much.

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 1, 2019

I am closing 19.3x branch soon with small bug fixes, and starting 19.4x. There I am adding new mail compose feature, and most likely, new read mail feature and other features, among which could be ACLs for File Manager.

Do you find this feature useful and worth time investments? I personally never had a need to deal with it. What are your real-life examples, when you would need it (just curious). I suppose it could go under existing Permissions modal, in case getfacl/setfacl commands are available and kernel supports it. Does device (fs) needs special acl flag upon mounting or it would just work?

@qwrty-ftw
Copy link

qwrty-ftw commented Aug 1, 2019

To be honest, I do not use ACL each day, but when I am using it, I prefer a graphical management, it's more clear, but i can deal with CLI.
I use ACL to manage user acces to specific files/folder.
For example many user/group can have RW acces to specific folder but not the other one.

But if it's not a hard work I would love see this improvement to your file manager :D

If i understand your last sentence, I think it's specific to each fs.
For example, like ZFS, I should specified the correct flag to use ACL. (zfs set acltype=posixacl )

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 1, 2019

@ochbob Okay, I'll look into it for 19.40 release. 😺

@snickers2k
Copy link

snickers2k commented Aug 6, 2019

+1 for ACL

two other things would be

  • small view/dropdown to monitor ongoing/historic operations like file-transfers etc.
  • split/dual-view

@xulinbao
Copy link

xulinbao commented Aug 7, 2019

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

Sorry, I just noticed the news, it is estimated that it is my local country network problem.

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 7, 2019

@ilinbxu Which country in particular is that?

@xulinbao
Copy link

xulinbao commented Aug 7, 2019

In China, after I opened the VPN, it was normal.

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 7, 2019

@ilinbxu Sorry to hear that, and I'm glad you're free from censorship now.

@sz00gun
Copy link

sz00gun commented Dec 20, 2020

well videojs is actively maintained, not sure about mediaelement

You won't find anything better than video.js

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 20, 2020

You won't find anything better than video.js

Okay, thanks, I will have a look and see if it fits. I am going to implement this the same way we do with photos, by gathering all videos from a directory and putting it into a playlist.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 24, 2020

The latest commit improves the search capability done using File Manager:

What was added for search:

  1. Ability to limit to user and group while searching
  2. Limit file size - you can use comparison operators, like < or >= or != or == as well as units like KiB or Mb or T for example to search only files larger than 1 megabyte you can go with >1M or >1 Mb or >1MiB or > 1024000
  3. Limit file type to File, Directory, Symlink - if directory is selected the file size filter will work on directories too!

Example:
image

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 25, 2020

I also added size range file search, which can be used to search files with size larger than and smaller than, like this:

Find all files larger than 3 MiB and smaller than 5 MiB:

>3M - <5M

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 31, 2020

I have finished work today on the theme 19.70-beta3 which adds a new cool feature to File Manager - ability to move files to Recycle Bin, rather than deleting completely.

Explanations on how it works:

  1. By default files are deleted as before (irreversibly - called delete option)

  2. Files now can be moved to trash (called remove option) by doing the following:
    2.1. Holding Alt key (Mac Option key) while context menu is opened
    2.2. Setting configuration option in module configuration called Delete files safely by moving to the trash to Yes.
           Note: if set to Yes, when holding Alt key, regular, irreversible delete option appear.

    image image

  3. Dialog window title, icon and button text, which pops up upon deletion will depend on the mode:
    image image

  4. Deleted files when moved to Trash will be placed under user home directory, i.e. ~/.Trash . Permissions on targeted files and directories will be saved. If there is a clash on directories or files found they will be appended with datetime string, like this:

/root/.Trash/home/ubuntu20-pro/public_html-2020-12-31_23:59:59

Looking forward for your suggestions and/or comments.


I wish everyone to have a great holidays and a happy new year!

@sz00gun
Copy link

sz00gun commented Dec 31, 2020

Wow! Amazing facility, however is possible to locate the .Trash folder in /home instead of /root ?

/root in my case don't have much left space, but /home have a lot, because there are all website.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 31, 2020

Wow! Amazing facility

Good to hear! 🙂

however is possible to locate the .Trash folder in /home instead of /root ?

Well, if files are deleted by the user (server owner) then they will be placed under /home, while if root user is deleting files, then files will be placed to /root because it defaults to home directory. Users without home will use / instead.

What I could theoretically do is to move files to /home/username/.Trash, if files were deleted from virtual server's home by root user (master administrator).

To summarize, right now, it's user based only but I could make it home dependable for virtual servers, the same way we automatically assign ownership to files created by root under virtual server's home.

Honestly I had this idea but I wasn't sure if files deleted by root should be moved under virtual server's home directory instead.

Perhaps adding another option (oh no) to File Manager configuration page, which would let define a single trash directory for all users? Then one could mount a super large drive to /mnt/.Trashed and collect trash for as long as needed?

@campones
Copy link

great work as usual, happy new year!

@mitchellkrogza
Copy link

Wow! Amazing facility

Good to hear!

however is possible to locate the .Trash folder in /home instead of /root ?

Well, if files are deleted by the user (server owner) then they will be placed under /home, while if root user is deleting files, then files will be placed to /root because it defaults to home directory. Users without home will use / instead.

What I could theoretically do is to move files to /home/username/.Trash, if files were deleted from virtual server's home by root user (master administrator).

To summarize, right now, it's user based only but I could make it home dependable for virtual servers, the same way we automatically assign ownership to files created by root under virtual server's home.

Honestly I had this idea but I wasn't sure if files deleted by root should be moved under virtual server's home directory instead.

Perhaps adding another option (oh no) to File Manager configuration page, which would let define a single trash directory for all users? Then one could mount a super large drive to /mnt/.Trashed and collect trash for as long as needed?

You are a STAR !!!! Thank you for adding this suggestion I sent you merely 3 days ago

@iliajie
Copy link
Collaborator Author

iliajie commented May 31, 2021

Upcoming Authentic Theme release will add support for displaying detailed file info, by clicking Alt+Enter or Command + I on a file while using keyboard navigation or calling it from the context menu. File checksums will also be displayed.

Example:

image
image

image

Note: I am looking extending this output with ACLs as well (when supported).


If there is anything missing or you wish to see any extra fields on the output that I missed, please let me know.

@Sopor
Copy link
Contributor

Sopor commented Dec 10, 2021

When sorting by size the directories will also be sorted by size even if it doesn't know the size of the directories.

I would like to have an option that always keep the directories at top and if it knows the size of the directories it should sort them too, but they should still be at the top.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 10, 2021

Good suggestion. Will do.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 10, 2021

Fixed.

@sz00gun
Copy link

sz00gun commented Dec 10, 2021

A very little problem with pop-ups in file manager on mobile phones. Eg. (?) Button and (bookmarks) button.
IMG_20211210_113436

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 10, 2021

Duh. Really annoying! Thanks for reporting. I'll have a look.

@WolfgangDpunkt
Copy link

2. Files now can be moved to trash (called remove option)

Is the recycle bin automatically emptied on a regular basis? This would be a nice feature.
Or does it have to be done manually?

I found the command in the context menu of the trash folder, maybe an improvment would be to include it centrally at the menu bar, for example within Tools? "Empty all recycle bins" or, for risk-averse users: "Purge all data in the recycle bin that is older than one month".

Thank you very much for this great software.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 14, 2021

Thank you very much for this great software.

Very welcome! 🙂

Is the recycle bin automatically emptied on a regular basis? This would be a nice feature. Or does it have to be done manually?

At the moment you would have to do it manually but adding a button to do it would probably be a good feature. Although it's not clear what root capable user action would be like -- would you expect it to be deleted for all users (like under /home)
or only for its own home dir?

Also, latest version can do purging trash by right clicking on it and choosing Empty Trash from context menu:

image

@WolfgangDpunkt
Copy link

I really appreciate your quick reply.

Also, latest version can do purging trash by right clicking on it and choosing Empty Trash from context menu

I had actually found that earlier, but more intuitive would probably really be a menu button.

I use Webmin as only user and admin on my RPI4, so I'm not representative for an multi-user perspective.
Maybe two options then? "Purge my trash" and "Purge all trash".

I personally will probably than use for automation purging simply a monthly cron task.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 14, 2021

Maybe two options then? "Purge my trash" and "Purge all trash".

Good suggestion. I'll think about adding it.

I personally will probably than use for automation purging simply a monthly cron task.

Yeah, this will work too.

@iliajie
Copy link
Collaborator Author

iliajie commented Dec 14, 2021

@sz00gun A very little problem with pop-ups in file manager on mobile phones. Eg. (?) Button and (bookmarks) button.

This is fixed. Thanks for reporting.

@iliajie
Copy link
Collaborator Author

iliajie commented Mar 28, 2022

I found the command in the context menu of the trash folder, maybe an improvment would be to include it centrally at the menu bar, for example within Tools? "Empty all recycle bins" or, for risk-averse users: "Purge all data in the recycle bin that is older than one month".

This feature will be implemented in upcoming Authentic Theme 19.91.1 release.

When move to trash option is activated it will be possible for master administrator to purge all trash directories for all users or only own trash directory:

image

@Mecha-Weasel
Copy link

Drooling over #13 "Edit/reorder bookmarks (not just delete/add)"

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 13, 2022

Drooling over #13 "Edit/reorder bookmarks (not just delete/add)"

I will look into adding it before a new theme release.

@qwrty-ftw
Copy link

Hello @iliajie

Any news about #23 ?

thank you !

@iliajie
Copy link
Collaborator Author

iliajie commented Nov 22, 2022

Any news about #23 ?

Never had a moment to implement ACLs controls. Although, listing been added a while ago and can be enabled in File Manager configuration.

@b-sullender
Copy link

When editing a text file using Webmin’s File Manager on an iPad the focus of input goes to the content filter, preventing me from entering text into the file. This might technically be a bug, but the option to turn off the content filter might be an easy and fast fix that adds more functionality.

@iliajie
Copy link
Collaborator Author

iliajie commented May 8, 2023

Thanks for the heads up. This issue has been fixed on the latest theme 20.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests