fix: handle an empty array for the ignored option

webpack · Aug 13, 2024 · cb9ab82 · cb9ab82
1 parent 585ebf9
commit cb9ab82
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/watchpack.js b/lib/watchpack.js
@@ -31,6 +31,9 @@ const stringToRegexp = ignored => {
 
 const ignoredToFunction = ignored => {
 	if (Array.isArray(ignored)) {
+		if (ignored.length === 0) {
+			return () => false;
+		}
 		const regexp = new RegExp(ignored.map(i => stringToRegexp(i)).join("|"));
 		return x => regexp.test(x.replace(/\\/g, "/"));
 	} else if (typeof ignored === "string") {

diff --git a/test/Watchpack.js b/test/Watchpack.js
@@ -269,6 +269,28 @@ describe("Watchpack", function() {
 		});
 	});
 
+	it("should watch a file in a directory when ignore is empty array", function(done) {
+		var w = new Watchpack({
+			aggregateTimeout: 300,
+			ignored: []
+		});
+		var changeEvents = 0;
+		w.on("change", function(file) {
+			file.should.be.eql(path.join(fixtures, "a"));
+			changeEvents++;
+		});
+		w.on("aggregated", function(changes) {
+			Array.from(changes).should.be.eql([path.join(fixtures, "a")]);
+			changeEvents.should.be.greaterThan(0);
+			w.close();
+			done();
+		});
+		w.watch([path.join(fixtures, "a")], []);
+		testHelper.tick(function() {
+			testHelper.file("a");
+		});
+	});
+
 	it("should watch a file then a directory", function(done) {
 		var w = new Watchpack({
 			aggregateTimeout: 1000