Separate Angular production vs non-production entries

[davidlj95]

This is a work in progress. #886 should be merged first to take that into account too. #884 should be merged first too in order for production mode to run. ✅

Some of the entry files added as part of Angular plugin are added as production entries. However they may not be production entries. Hence causing production mode to not work as expected.

Configuration for building an Angular project is usually specified under the build target inside the architect object of the Angular CLI workspace (aka angular.json). However, right now the implementation is using configuration options from all targets. Which is good to capture also build options like when building for testing within the test target. However, in that scenario, the entries added should be non-production ones.

Also, in any architect target options, the options defined in there are the default values for that target. But they may be overridden when specifying one or more alternative configurations. From those, the production configuration will contain production options and the rest are very probably non-production ones.

Here are the options from which we're adding entries and the Angular CLI's builders they can be used with

Option	Webpack	Karma (test)	ESBuild browser	ESBuild app (@angular-devkit) / ESBuild app (@angular/build)
main	X	X
scripts	X	X	X	X
fileReplacements	X	X	X	X
browser				X
server				X
ssr.entry				X

This PR does two main things:

1. Refactors to read entry files/patterns from both default options and also from each of the configurations defined. This is an additional feature, as previously entries defined in configurations weren't read (apart from fileReplacement ones)
2. Add as production entries only the entries for the build target in production configuration. Takes into account that if an option isn't defined in the production configuration (if any), the default option will be used instead. Rest of entries will be development ones

Also the order of options has been changed so that they appear more or less chronologically ascendent. For instance, main option comes from the classic / old Webpack builder so appears first than newer browser option in application builder.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/knip@887

commit: c9b3416

[webpro]

Thanks a bunch, David. This is all great, just a nitpick left.

[webpro]

Just went ahead and merged to prepare for the next release. Thanks a bunch again, David!

[webpro]

🚀 This pull request is included in v5.42.0. See Release 5.42.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.