Only download and parse seed files once #908
Closed
+404
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
force-pushed
the
issue-897-seedfile-expiration
branch
3 times, most recently
from
dee29ca to
7c409f6
Compare
tw4l
force-pushed
the
issue-897-seedfile-expiration
branch
from
f970dd8 to
610b774
Compare
Use hacky any to avoid circular import, will fix properly in later commit
Also move parseSeeds to separate module to avoid circular import
Allow crawlState to be undefined in parseSeeds for use in scope tests
tw4l
force-pushed
the
issue-897-seedfile-expiration
branch
3 times, most recently
from
a603ec9 to
2899593
Compare
The only information in seed files is the URL, so no need to complicate things by storing more than that.
tw4l
force-pushed
the
issue-897-seedfile-expiration
branch
from
ae4321b to
df395a7
Compare
tw4l
changed the title
Member
Author
|
@ikreymer This is now ready for review! |
Member
Author
|
Closing in favor of #921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #897
parseSeedsinto its own module to avoid circular importsManually tested with pausing crawls in Browsertrix and with picking up from interrupted crawls via serialized state YAML files with the crawler, in addition to tests added.