-
-
Notifications
You must be signed in to change notification settings - Fork 56
Update superadmin quota dialog with relative changes & presets #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emma-sg
wants to merge
17
commits into
main
Choose a base branch
from
admin-relative-execution-minutes-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updates the org quota editor to allow both adjustment values and direct value editing for quotas other than additional/gifted execution minutes
3663e35
to
caeceb5
Compare
ikreymer
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We may move the plans to a separate configmap/secret later, but this should be good for now!
ikreymer
reviewed
Sep 25, 2025
ikreymer
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2824
Changes
min
,max
, andstep
props fornumber
input types)available_plans
to a JSON string matching thePlansResponse
object type. If unset, the presets section will show a single "unset" preset.Testing
This should be tested with both frontend and backend deployed with these changes, so you might want to test locally or deploy to dev.
Screenshots
Testing
All tested locally against dev.
Footnotes
We're pretty limited by Lit's lack of support for generics in element types, so there's a few errors from lit-analyzer that are a little tricky to get around, but iirc work is being done to get closer to this! So we might not need to switch to JSX for this to be supportable in the future. ↩