task: Add dedupe form control to workflow #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
approved these changes
Nov 3, 2025
|
|
||
| Cron schedules are always in [UTC](https://en.wikipedia.org/wiki/Coordinated_Universal_Time). | ||
|
|
||
| ## Deduplication |
Member
There was a problem hiding this comment.
We should add more documentation before merging the feature branch to main. Appreciate you adding this here as a stub/reminder
SuaYoo
force-pushed
the
feature-dedupe
branch
from
3fc36fb to
2fcf6d7
Compare
SuaYoo
force-pushed
the
feature-dedup--frontend-dedupe-form
branch
from
452568c to
e4378a2
Compare
emma-sg
added a commit
that referenced
this pull request
Nov 5, 2025
commit 43c4dc2 Author: sua yoo <[email protected]> Date: Mon Nov 3 09:12:50 2025 -0800 task: Add dedupe form control to workflow (#2932) - Adds new "Deduplication" section to workflows - Allows users to use a collection for deduplication - Various refactors for consistency commit 2fcf6d7 Author: Ilya Kreymer <[email protected]> Date: Tue Oct 28 09:47:25 2025 -0700 Dedup Backend Initial Implementation (#2868) Fixes #2867 The backend implementation involves: Operator - A new CollIndex CRD type, btrix-crds updated to 0.2.0 - Operator that manages the new CRD type, creating a new Redis instance when the index should exist (uses redis_dedupe_memory and redis_dedupe_storage chart values) - dedupe_importer_channel can configure crawler channel for index imports - Operator starts the crawler in 'indexer' mode Workflows & Crawls: - Workflows have a new 'dedupeCollId' field for dedupe while crawling The `dedupeCollId` must also be a collection that the crawl is auto-added to. - There is a new waiting state: `waiting_for_dedupe_index` that is entered if a crawl is starting, but index is not yet ready. - Each crawl has bi-directional links for crawls that it requires for dedupe via `requiresCrawls` and other crawls for which this crawl is required via `requiredByCrawls`. - autoAddCollections automatically updated to always include `dedupeCollId` collection. Collection: - Collection has a new `hasDedupeIndex` field - Items added/removed to/from collection result in marking CollIndex object for updates by updating collItemsUpdatedAt timestamp to trigger a reindex - CollIndex object deleted on collection delete For indexing, dependent on version of crawler from webrecorder/browsertrix-crawler#884 that supports indexing mode. --------- Co-authored-by: Tessa Walsh <[email protected]>
ikreymer
pushed a commit
that referenced
this pull request
Nov 5, 2025
- Adds new "Deduplication" section to workflows - Allows users to use a collection for deduplication - Various refactors for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2862
Depends on #2868
Changes
Screenshots
Follow-ups
This PR adds a section to the user guide, which will be filled out as a part of #2933