profile constraint follow-up: #3009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Nov 21, 2025
ikreymer
commented
- follow-up to profile constraints improvements #2988, alternative to WIP: Update related workflow proxies on profile proxy is updated #3008
- clear proxyId in workflow if using profile, ensure it is always empty for new workflows/updated workflows that have a profile
- add migration to clear proxyId if profileid is set for existing workflows
- avoids having to update proxyId in workflows when it changes in the profile
- fix assertion when updating proxy to return 400 if proxy is invalid
- follow-up to #2988, alternative to #3008 - clear proxyId in workflow if using profile, ensure it is always empty for new workflows/updated workflows that have a profile - add migration to clear proxyId if profileid is set for existing workflows - avoids having to update proxyId in workflows when it changes in the profile - fix assertion when updating proxy to return 400 if proxy is invalid
also clear proxyId if profileid is set
tw4l
reviewed
Nov 24, 2025
tw4l
reviewed
Nov 24, 2025
ikreymer
commented
Nov 24, 2025
backend/btrixcloud/migrations/migration_0054_clear_proxyid_when_using_profiles.py
Outdated
Show resolved
Hide resolved
tw4l
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.