Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSE: Add abort and closed methods #21

Merged
merged 5 commits into from
Nov 5, 2024
Merged

SSE: Add abort and closed methods #21

merged 5 commits into from
Nov 5, 2024
+71 −17

Conversation

AlexanderKolberg
Copy link
Contributor

No description provided.

@AlexanderKolberg AlexanderKolberg marked this pull request as ready for review November 4, 2024 20:09
VojtechVitek
VojtechVitek reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) One suggestion

Let's try it on the main webrpc repo

_examples/sse/webapp/client.gen.ts Show resolved Hide resolved
@AlexanderKolberg
Copy link
Contributor Author

Looks good :) One suggestion

Let's try it on the main webrpc repo

webrpc/webrpc#311

@VojtechVitek VojtechVitek merged commit 330b647 into master Nov 5, 2024
1 check passed
@VojtechVitek VojtechVitek deleted the sse-improvments branch November 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderKolberg @VojtechVitek