Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string and remove revision #81

Merged

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Dec 6, 2020

Not clean the reason behind $Revision$ is it supposed to be replacable on packaging?

That's mostly from #80 and #79 (comment)

@TysonAndre
Copy link
Contributor

Not clean the reason behind $Revision$ is it supposed to be replacable on packaging?

It's an svn feature, but this repo moved to git so it's no longer needed. See https://stackoverflow.com/a/2009905
Taking it out makes sense since this no longer uses svn.

@andypost
Copy link
Contributor Author

andypost commented Dec 6, 2020

@TysonAndre Thank you! good know) I used to transition from cvs to git, lucky bypassed svn)

@tomassrnka
Copy link
Member

Thank you very much!

@tomassrnka tomassrnka merged commit 0fa35c0 into websupport-sk:NON_BLOCKING_IO_php8 Dec 6, 2020
@andypost andypost deleted the 79-version-fix branch December 6, 2020 20:29
@andypost
Copy link
Contributor Author

andypost commented Dec 6, 2020

Thank you! Wondered that php has no script to bump version on release

@nono303 nono303 mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants