-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backoff algorithm #136
base: master
Are you sure you want to change the base?
Backoff algorithm #136
Conversation
Problem with travis failing is that older versions of node don't have |
@lmatteis We already depend on https://www.npmjs.com/package/buffer-equals -- you can just use that. |
@feross ah sweet. works! |
@mafintosh Do you have any thoughts on this PR? It's been a while and I think we should merge or close at this point. I'm not familiar with the spec in question, so I'll defer to you |
Yea, I need to take a closer look. I'll try to make some time over the next week to do so |
An important change is inside the
_closest()
method, where I also store thev
property found in replies. This could potentially increase memory footprint of a node. But I need to store the values somewhere to be able to compare them for the backoff algorithm.For info on the algorithm check the newly added Expiration section here: http://bittorrent.org/beps/bep_0044.html
Discussion #135